Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0.5 Release #340

Merged
merged 5 commits into from
Jan 6, 2025
Merged

3.0.5 Release #340

merged 5 commits into from
Jan 6, 2025

Conversation

rgomezp
Copy link
Contributor

@rgomezp rgomezp commented Jan 6, 2025

One line summary

Revert and fix push title/content logic, handle missing UTM params, and update outdated WordPress documentation links.

Description

This update includes multiple changes aimed at improving functionality and maintaining accuracy:

  • Reverted push notification logic: Adjusted to set the push title to the site name and the push content to the post title. This reverts to pre-3 behavior.
  • Handled missing UTM parameters: Fixed an issue where the absence of UTM parameters could trigger warnings about undefined array keys.
  • Updated WordPress documentation links: Replaced outdated links with the consolidated /wordpress URL structure for better accessibility and relevance.

These changes address notification formatting, error handling, and documentation accuracy.


This change is Reviewable

Motivation: Set the push title to the site name
Set the push content to the post title
@rgomezp rgomezp requested review from jkasten2 and sherwinski January 6, 2025 22:41
Rodrigo Gomez Palacio added 4 commits January 6, 2025 17:10
Motivation: leading to a warning of undefined array key
Motivation: tooltip wasn't rendering. We need to switch to use the new jquery approach introduced in v3
Motivation: consolidated into /wordpress
Release commit
@rgomezp rgomezp merged commit 9728f01 into main Jan 6, 2025
1 check passed
@rgomezp rgomezp deleted the 3.0.5 branch January 6, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants