Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

atanh module #4960

Merged
merged 29 commits into from
Jun 4, 2021
Merged

atanh module #4960

merged 29 commits into from
Jun 4, 2021

Conversation

WangYizhang01
Copy link
Contributor

@WangYizhang01 WangYizhang01 commented May 21, 2021 •
edited
Loading

atanh
tan
截屏2021-06-03 下午12 36 19
截屏2021-06-03 下午12 37 18

@CLAassistant
Copy link

CLAassistant commented May 21, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@WangYizhang01 WangYizhang01 mentioned this pull request May 21, 2021
Closed
@WangYizhang01 WangYizhang01 marked this pull request as draft May 28, 2021 03:24
@WangYizhang01 WangYizhang01 requested a review from doombeaker May 28, 2021 03:24
@oneflow-ci-bot oneflow-ci-bot removed their request for review May 28, 2021 03:26
@WangYizhang01 WangYizhang01 marked this pull request as ready for review May 28, 2021 03:27
@oneflow-ci-bot oneflow-ci-bot removed their request for review May 28, 2021 10:13
BBuf
BBuf reviewed May 31, 2021
View reviewed changes
oneflow/python/test/modules/test_square.py Outdated
limitations under the License.
"""
import unittest
from collections import OrderedDict
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个PR为什么会改square和sqrt的测试？

BBuf
BBuf reviewed May 31, 2021
View reviewed changes
oneflow/python/test/modules/test_tan.py
from test_util import GenArgList


def _test_tan_impl(test_case, shape, device):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

测试样例中缺少对Tensor.xxx方法的测试，Tensor.xxx方法的测试放到test_tensor.py中。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BBuf

@WangYizhang01 WangYizhang01 requested a review from BBuf May 31, 2021 03:14
@oneflow-ci-bot oneflow-ci-bot removed their request for review June 4, 2021 05:20
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot June 4, 2021 05:53
@oneflow-ci-bot oneflow-ci-bot self-requested a review June 4, 2021 06:55
@aajjjtntn
Update test_atanh.py
d726d7b 
use arg_dict[test_fun"]
@oneflow-ci-bot oneflow-ci-bot removed their request for review June 4, 2021 07:31
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot June 4, 2021 08:17
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot June 4, 2021 09:33
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot June 4, 2021 10:33
@oneflow-ci-bot oneflow-ci-bot self-requested a review June 4, 2021 11:16
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot June 4, 2021 12:06
@oneflow-ci-bot oneflow-ci-bot merged commit 9583290 into master Jun 4, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the wyz branch June 4, 2021 12:54
@jackalcooper jackalcooper changed the title init atanh atanh module Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BBuf BBuf BBuf approved these changes

@Ldpe2G Ldpe2G Awaiting requested review from Ldpe2G

@doombeaker doombeaker Awaiting requested review from doombeaker doombeaker is a code owner

Assignees
No one assigned
Labels
api automerge enhancement feature op
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@WangYizhang01 @CLAassistant @BBuf @doombeaker @oneflow-ci-bot @aajjjtntn @jackalcooper