add mseloss module #5116
Merged
add mseloss module #5116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
YongtaoShi
commented
Jun 7, 2021
•
YongtaoShi
commented
|
@doombeaker @Flowingsun007 @BBuf |
BBuf
reviewed
Jun 8, 2021
oneflow/python/nn/modules/loss.py
Outdated
| "none", | ||
| "mean", | ||
| None, | ||
| ], "only 'sum', 'mean' and None supported by now" |
There was a problem hiding this comment.
这里修改一下，类似于reduction parameter only support 'sum'/'mean'/'none'/None value now！
BBuf
reviewed
Jun 8, 2021
| test_case.assertTrue(np.allclose(input.grad.numpy(), np_grad, 1e-5, 1e-5)) | ||
|
|
||
|
|
||
| def _test_mseloss_one_elem_input_backward(test_case, device, reduction): |
There was a problem hiding this comment.
既然numpy实现了forward和backward，那么这些测试样例都可以合并，通过设置shape来统一测试。
BBuf
reviewed
Jun 8, 2021
| } | ||
|
|
||
|
|
||
| def _test_mseloss_backward(test_case, device, shape, reduction): |
BBuf
approved these changes
Jun 8, 2021
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
…nc/oneflow into shiyongtao/dev_mseloss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.