add pixel_shuffle module #5135
Merged
add pixel_shuffle module #5135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
YongtaoShi
commented
Jun 8, 2021
•
YongtaoShi
commented
…shiyongtao/dev_pixel_shuffle
| C_{out} = C_{in} \div \text{upscale\_factor}^2 | ||
|
|
||
| .. math:: | ||
| H_{out} = H_{in} \times \text{upscale\_factor} |
| ), "The scale factor of height and width must larger than zero" | ||
| self.h_upscale_factor = h_upscale_factor | ||
| self.w_upscale_factor = w_upscale_factor | ||
| self._transpose_op = ( |
There was a problem hiding this comment.
不需要在init里构造transpose_op了，forward里可以直接用flow.permute()，等后面的functional接口更新以后，后面都会重构成类似torch那样，直接F.permute(xxx)
|
|
||
|
|
||
| def _np_pixel_shuffle(input, factor): | ||
| return _np_pixel_shuffle_v2(input, factor, factor) |
There was a problem hiding this comment.
这里不需要包一层，直接用_np_pixel_shuffle就行
| return self._pixel_shuffle_v2_op(input) | ||
|
|
||
|
|
||
| class PixelShufflev2(Module): |
There was a problem hiding this comment.
PixelShufflev2这个只是我们lazy op的版本区分，新版nn.Module中直接对齐torch，叫PixelShuffle吧
There was a problem hiding this comment.
对，pytorch只有pixelshuffle。
现在问题是，在之前的lazy模式，pixelshuffle是用pixelshufflev2来实现的，我现在采用了和lazy一样的逻辑。然后没有export v2接口，所以在用户看来应该是和pytorch一致的。
这样做的好处是，如果以后有v2需求的话，可以直接复用。也包括上面的numpy代码实现。
There was a problem hiding this comment.
如果确实不需要的话，是有些冗余，那我把v2相关的都删了？
Flowingsun007
approved these changes
Jun 9, 2021
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.