GDB-10752 Add password hash for the security provisioner #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change should be in the 11.2 feature branch. |
mihailradkov
reviewed
Sep 3, 2024
cloudvlad
force-pushed
the
GDB-10752_add_security_password_hash
branch
2 times, most recently
from
b904602 to
ecb8578
Compare
cloudvlad
force-pushed
the
GDB-10752_add_security_password_hash
branch
3 times, most recently
from
d65f374 to
d395207
Compare
mihailradkov
reviewed
Sep 4, 2024
cloudvlad
force-pushed
the
GDB-10752_add_security_password_hash
branch
3 times, most recently
from
075173d to
eb757d1
Compare
cloudvlad
force-pushed
the
GDB-10752_add_security_password_hash
branch
2 times, most recently
from
3b29772 to
4f36047
Compare
cloudvlad
force-pushed
the
GDB-10752_add_security_password_hash
branch
from
c4dcf51 to
f772709
Compare
mihailradkov
approved these changes
Sep 12, 2024
Secchol
reviewed
Sep 18, 2024
| @@ -258,6 +258,10 @@ security: | |||
| # Note: The user is created regardless of if the existingSecret is provided or not. | |||
| username: provisioner | |||
| password: iHaveSuperpowers | |||
| # Define an initial password for the provisioner user as a bcrypt hash. | |||
| # If the password is not specified, it will use the default one specified in the provisioner.password. | |||
| # Important: This value must be a bcrypt encrypted hash, not a plaintext string. The format is "{bcrypt}<the-encrypted-hash>" | |||
There was a problem hiding this comment.
Make the "{bcrypt}" prefix automatically be added to the hash in the user.js file so the user only has to input the hash. This improves the user experience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The password hash is introduced due to the dynamic nature of the bcrypt algorithm, which generates a new hash each time deployment is initiated.
This resolves potential issues with CI/CD tools that detect these changes and prevent false-positive drift events.
Issue: GDB-10752
#118