TES-381 Added provisioning of graphdb backup script #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
files/graphdb_backup
Outdated
|
|
||
| az login --identity | ||
|
|
||
| RESOURCE_GROUP="$(curl -s -H Metadata:true "http://169.254.169.254/metadata/instance/compute/resourceGroupName?api-version=2021-01-01&format=text")" |
There was a problem hiding this comment.
I don't like these variables here. I could use the image with another user data script when creating VMs, we should not restrict this, IMO. Also, the way how the script assumes that the first storage account and app config are the ones to be used... it's wrong as it is not portable to most subscriptions. Better to pass the variables as arguments.
viktor-ribchev
force-pushed
the
TES-381
branch
from
ad326e3 to
d93229a
Compare
variables.pkr.hcl
Outdated
| variable use_azure_cli_auth { | ||
| description = "CLI auth will use the information from an active az login session to connect to Azure and set the subscription id and tenant id associated to the signed in account." | ||
| type = bool | ||
| default = false |
There was a problem hiding this comment.
Let's make this true by default?
files/graphdb_backup
Outdated
|
|
||
| az login --identity | ||
|
|
||
| GRAPHDB_ADMIN_PASSWORD="$(az appconfig kv show --name ${1} --auth-mode login --key graphdb-password | jq -r .value | base64 -d)" |
There was a problem hiding this comment.
Can't we provide it? It's coupling the script to KV.
yaskoo
approved these changes
Jan 26, 2024
files/graphdb_backup
Outdated
|
|
||
| # Checks if GraphDB is running in cluster | ||
| IS_CLUSTER=$( | ||
| curl -s -o /dev/null \ |
mihailradkov
approved these changes
Jan 29, 2024
yaskoo
approved these changes
Jan 29, 2024
Added provisioning of GraphDB backup script. Added keepalive and file max size settings. Improved logging of the GraphDB install script. Added script descriptions Removed dependency on application config resource from backup script Added support for single instance GDB to the backup script Changed use_azure_cli_auth to true
viktor-ribchev
force-pushed
the
TES-381
branch
from
24a6129 to
eac5fea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added installation of Telegraf.
Added provisioning of GraphDB backup script.
Added keepalive and file max size settings.
Improved logging of the GraphDB install script.
Related Issues
TES-381
Changes
Added installation of Telegraf.
Added provisioning of GraphDB backup script.
Added keepalive and file max size settings.
Improved logging of the GraphDB install script.
Screenshots (if applicable)
N/A
Checklist