Skip to content

Commit

Permalink
[GDB-10116] Fix Comments
Browse files Browse the repository at this point in the history
  • Loading branch information
simonzhekoff committed Apr 22, 2024
1 parent b96e087 commit d2b0d66
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
11 changes: 11 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,17 @@ deploy_monitoring = true
lb_tls_certificate_arn = "arn:aws:acm:us-east-1:123456789012:certificate/12345678-1234-1234-1234-123456789012"
```

**Private Deployment**

To ensure access to GraphDB exclusively through a private network, you must set the following variables to `true`:
```hcl
# Enable creation of a private service endpoint
lb_enable_private_access = true
# Enable private access to the Network Load Balancer and disable public access
lb_internal = true
```
By configuring these variables accordingly you enforce GraphDB accessibility solely via a private network, enhancing security and control over network traffic.

## Local Development

Instead of using the module dependency, you can create a local variables file named `terraform.tfvars` and provide
Expand Down
3 changes: 2 additions & 1 deletion modules/graphdb/nsg.tf
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ resource "aws_security_group_rule" "graphdb_network_lb_ingress" {
}

resource "aws_security_group_rule" "graphdb_lb_healthchecks" {
count = var.lb_enable_private_access ? 0 : 1 # Since it creates duplicated rule if lb_internal is true we need to have a toggle to enable/disable this rule based on the type of the access to the LB
# Since it creates duplicated rule if lb_internal is true we need to have a toggle to enable/disable this rule based on the type of the access to the LB
count = var.lb_enable_private_access ? 0 : 1

description = "Allow the load balancer to healthcheck the GraphDB nodes and access the proxies."
security_group_id = aws_security_group.graphdb_security_group.id
Expand Down

0 comments on commit d2b0d66

Please sign in to comment.