Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to use CMK keys for most of the services #50

Merged
2 commits merged into from
Jul 5, 2024
Merged

Add ability to use CMK keys for most of the services #50

2 commits merged into from
Jul 5, 2024

Conversation

kristianiliev1
Copy link
Contributor

@kristianiliev1 kristianiliev1 commented Jun 3, 2024 •
edited by jira bot
Loading

Description

Added KMS CMK Encryption to S3 Bucket with an option to toggle ON or OFF

Related Issues

GDB-10329

Changes

Also changed 1 variable name, since we will have more similar ones to avoid confusion

Screenshots (if applicable)

Checklist

  • I have tested these changes thoroughly.
  • My code follows the project's coding style.
  • I have added appropriate comments to my code, especially in complex areas.
  • All new and existing tests passed locally.

@kristianiliev1 kristianiliev1 requested review from a user and viktor-ribchev June 3, 2024 09:24
ghost
ghost reviewed Jun 3, 2024
View reviewed changes
modules/backup/cmk.tf Outdated Show resolved Hide resolved
ghost
ghost reviewed Jun 3, 2024
View reviewed changes
modules/backup/cmk.tf Outdated Show resolved Hide resolved
viktor-ribchev
viktor-ribchev reviewed Jun 3, 2024
View reviewed changes
modules/backup/variables.tf Outdated Show resolved Hide resolved
modules/backup/variables.tf Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@kristianiliev1 kristianiliev1 marked this pull request as ready for review June 12, 2024 09:07
ghost
ghost reviewed Jun 13, 2024
View reviewed changes
modules/graphdb/cmk-ebs.tf Show resolved Hide resolved
modules/graphdb/cmk-ebs.tf Outdated Show resolved Hide resolved
modules/graphdb/cmk-ebs.tf Outdated Show resolved Hide resolved
modules/graphdb/cmk-parameter-store.tf Outdated Show resolved Hide resolved
modules/graphdb/cmk-parameter-store.tf Outdated Show resolved Hide resolved
modules/graphdb/cmk-parameter-store.tf Outdated Show resolved Hide resolved
modules/graphdb/iam.tf Outdated Show resolved Hide resolved
modules/graphdb/templates/02_disk_management.sh.tpl Outdated Show resolved Hide resolved
modules/monitoring/cmk.tf Outdated Show resolved Hide resolved
modules/backup/cmk.tf Outdated Show resolved Hide resolved
ghost
ghost reviewed Jun 13, 2024
View reviewed changes
main.tf Outdated Show resolved Hide resolved
viktor-ribchev
viktor-ribchev reviewed Jun 24, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
ghost
ghost reviewed Jun 24, 2024
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
@ghost ghost force-pushed the GDB-10329-encrypt-services branch from b7b5d7f to 10ce7ea Compare July 2, 2024 06:32
@viktor-ribchev
Copy link
Contributor

Update the CHANGELOG.md

@ghost ghost force-pushed the GDB-10329-encrypt-services branch 5 times, most recently from 1525916 to b388160 Compare July 3, 2024 10:49
viktor-ribchev
viktor-ribchev reviewed Jul 3, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
modules/graphdb/cmk-ebs.tf Outdated Show resolved Hide resolved
modules/graphdb/cmk-parameter-store.tf Outdated Show resolved Hide resolved
modules/graphdb/variables.tf Show resolved Hide resolved
modules/monitoring/cmk.tf Show resolved Hide resolved
modules/monitoring/iam.tf Outdated Show resolved Hide resolved
modules/monitoring/variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
@ghost ghost force-pushed the GDB-10329-encrypt-services branch from 829bd65 to 019c73d Compare July 3, 2024 13:31
viktor-ribchev
viktor-ribchev reviewed Jul 4, 2024
View reviewed changes
main.tf Outdated Show resolved Hide resolved
@ghost ghost force-pushed the GDB-10329-encrypt-services branch from 4db7534 to 83652a3 Compare July 4, 2024 10:11
@ghost ghost changed the title Add kms encryption to s3 bucket Add ability to use CMK keys for most of the services Jul 4, 2024
viktor-ribchev
viktor-ribchev reviewed Jul 4, 2024
View reviewed changes
modules/backup/outputs.tf Show resolved Hide resolved
modules/backup/outputs.tf Outdated Show resolved Hide resolved
modules/backup/variables.tf Show resolved Hide resolved
modules/graphdb/cmk-ebs.tf Outdated Show resolved Hide resolved
modules/graphdb/cmk-ebs.tf Outdated Show resolved Hide resolved
modules/graphdb/cmk-parameter-store.tf Outdated Show resolved Hide resolved
modules/graphdb/outputs.tf Outdated Show resolved Hide resolved
modules/monitoring/cmk.tf Outdated Show resolved Hide resolved
@ghost ghost force-pushed the GDB-10329-encrypt-services branch 2 times, most recently from d30b1b2 to 61aa3ff Compare July 4, 2024 12:25
mihailradkov
mihailradkov reviewed Jul 5, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
modules/graphdb/user_data.tf Outdated Show resolved Hide resolved
modules/graphdb/variables.tf Outdated Show resolved Hide resolved
@ghost ghost force-pushed the GDB-10329-encrypt-services branch from f99c6c1 to 4a91c97 Compare July 5, 2024 08:57
@ghost ghost force-pushed the GDB-10329-encrypt-services branch from 04b5aeb to 4e871aa Compare July 5, 2024 08:58
@ghost ghost merged commit 682db50 into main Jul 5, 2024
@ghost ghost deleted the GDB-10329-encrypt-services branch July 5, 2024 15:14
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viktor-ribchev viktor-ribchev viktor-ribchev approved these changes

@mihailradkov mihailradkov mihailradkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kristianiliev1 @viktor-ribchev @mihailradkov