Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues from first playtest #62

Merged

Conversation

out-of-phaze
Copy link
Member

@out-of-phaze out-of-phaze commented Jun 2, 2024

Description of changes

Upstreamed changes:

Makes certain coating checks check total volume instead of just if the datum exists.
Makes loot piles use the lazylist macros for searched_by.
Reorders certain HUD calls.
Removes invalid parent call return value check in ghost Life().
Adds 'remove chargestick' modular computer alt interaction.
Makes the 'remove ID card' modular computer alt interaction only show up when there is an ID to remove.
Adds a config option to have lightswitches start on.
Implements a stopgap for air alarm trace gases, by adding gases from the filtered/dangerous gases list to the trace gases list. TODO: Cached list of materials by state at STP,.. OR just have the trace gas amount be 100 - every_other_gas.
Makes regex chat filters reset their index after one use.
Makes markdown chat filters use REGEX_QUOTE for format_char.
Rewrites autopunctuation and format_emote/format_say_message. Trims trailing and leading whitespace from messages prior to autopunctuation. Autopunctuation now runs after chat modification filters, so the HTML can be trivially stripped when checking for punctuation.

Downstream changes:

Adjusts PTO types and timeoff factors for jobs.
Adds Command off-duty role.
Makes Tether research HUD icons Research-colored instead of blue.
Improves NIFHud code.
Makes the tram work.
Makes tail secondary colors work.

Why and what will this PR improve

Upstreamed changes

Fix false-positives in stained item messages when the coating datum exists but is empty.
Fixes runtimes when searching loot piles.
Allows all methods of getting a HUD, not just HUD glasses, to work. (Anything that comes after the clear call, anyway.)
Fixes Ghost Medic HUDs not showing up.
Adds a way to remove chargesticks without using the right-click menu.
Prevents confusion by contextually hiding/showing the 'remove ID card' interaction.
Allows servers to configure whether their maps look empty and deserted at roundstart.
Temporarily fixes downstream issues with phoron (/datum/material/solid/phoron) not showing up in air alarm trace gases, without having to add an explicit reference to phoron.
Fixes regex chat filters having weird stateful behavior on repeated messages, causing them to not detect a message every other time it's repeated without a message in-between.
format_char for markdown filters no longer has to be manually escaped and can just be "*" or "_".
Autopunctuation now gracefully handles HTML tags and trailing whitespace, avoiding issues like

Annabelle Whitefur says, "This. ."

and

Cassandra Cressmann says, "This.."

Downstream changes

NIFHUDs work properly now.
Command can go off-duty as a special role (note: they can't go back on duty as a Command role! this is intended!)
Lets the tram be used to end the round.
Tails will now use their secondary color for extra overlays, rather than your hair color.

Authorship

me

Changelog

🆑
add: Added Off-Duty Command role.
add: Added a functional tram to the Lighthouse map.
/:cl:

@out-of-phaze out-of-phaze marked this pull request as ready for review June 2, 2024 21:54
@out-of-phaze out-of-phaze force-pushed the lighthouse-fix/playtest-issues branch from 343e4ee to c202960 Compare June 3, 2024 05:07
@out-of-phaze out-of-phaze merged commit 5d838a3 into OpaqueSunset:master Jun 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant