Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Upstreamed changes:
Makes certain coating checks check total volume instead of just if the datum exists.
Makes loot piles use the lazylist macros for
searched_by
.Reorders certain HUD calls.
Removes invalid parent call return value check in ghost Life().
Adds 'remove chargestick' modular computer alt interaction.
Makes the 'remove ID card' modular computer alt interaction only show up when there is an ID to remove.
Adds a config option to have lightswitches start on.
Implements a stopgap for air alarm trace gases, by adding gases from the filtered/dangerous gases list to the trace gases list. TODO: Cached list of materials by state at STP,.. OR just have the trace gas amount be
100 - every_other_gas
.Makes regex chat filters reset their index after one use.
Makes markdown chat filters use REGEX_QUOTE for format_char.
Rewrites autopunctuation and format_emote/format_say_message. Trims trailing and leading whitespace from messages prior to autopunctuation. Autopunctuation now runs after chat modification filters, so the HTML can be trivially stripped when checking for punctuation.
Downstream changes:
Adjusts PTO types and timeoff factors for jobs.
Adds Command off-duty role.
Makes Tether research HUD icons Research-colored instead of blue.
Improves NIFHud code.
Makes the tram work.
Makes tail secondary colors work.
Why and what will this PR improve
Upstreamed changes
Fix false-positives in stained item messages when the coating datum exists but is empty.
Fixes runtimes when searching loot piles.
Allows all methods of getting a HUD, not just HUD glasses, to work. (Anything that comes after the clear call, anyway.)
Fixes Ghost Medic HUDs not showing up.
Adds a way to remove chargesticks without using the right-click menu.
Prevents confusion by contextually hiding/showing the 'remove ID card' interaction.
Allows servers to configure whether their maps look empty and deserted at roundstart.
Temporarily fixes downstream issues with phoron (
/datum/material/solid/phoron
) not showing up in air alarm trace gases, without having to add an explicit reference to phoron.Fixes regex chat filters having weird stateful behavior on repeated messages, causing them to not detect a message every other time it's repeated without a message in-between.
format_char
for markdown filters no longer has to be manually escaped and can just be"*"
or"_"
.Autopunctuation now gracefully handles HTML tags and trailing whitespace, avoiding issues like
and
Downstream changes
NIFHUDs work properly now.
Command can go off-duty as a special role (note: they can't go back on duty as a Command role! this is intended!)
Lets the tram be used to end the round.
Tails will now use their secondary color for extra overlays, rather than your hair color.
Authorship
me
Changelog
🆑
add: Added Off-Duty Command role.
add: Added a functional tram to the Lighthouse map.
/:cl: