[VT]: Add state tracker and updater for active masks #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GwnDaan
added
enhancement
GwnDaan
force-pushed
the
daan/vt-state-track-active-masks
branch
2 times, most recently
from
fbc4c39 to
17e31c3
Compare
ad3154
reviewed
Jan 21, 2024
isobus/include/isobus/isobus/isobus_virtual_terminal_client.hpp
Outdated
Show resolved
Hide resolved
GwnDaan
force-pushed
the
daan/vt-track-and-update-states
branch
from
b6387b0 to
49c535b
Compare
GwnDaan
force-pushed
the
daan/vt-state-track-active-masks
branch
3 times, most recently
from
54a3249 to
1e43105
Compare
GwnDaan
force-pushed
the
daan/vt-track-and-update-states
branch
2 times, most recently
from
f523b83 to
08bccba
Compare
GwnDaan
force-pushed
the
daan/vt-state-track-active-masks
branch
from
1e43105 to
1126c9d
Compare
|
Since you've got this one set to merge into daan/vt-track-and-update-states should we do reviews on this one before merging that one to main? |
Hmm, I'd prefer the opposite. If we merge the other one first, then this will simply be based upon main. Will make things a bit less complicated I think |
GwnDaan
force-pushed
the
daan/vt-state-track-active-masks
branch
from
89832c7 to
bb10de8
Compare
GwnDaan
force-pushed
the
daan/vt-state-track-active-masks
branch
from
bb10de8 to
c84e457
Compare
ad3154
approved these changes
Jan 28, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sequel of #405 and part of #403. With this addition you can update active masks with the helper class. The benefit is that you don't have to do any preliminary checks whether or not the update is necessary, the helper class will do that for you