Add infrastructure for VT identify message handling in AgIsoVt #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ad3154
reviewed
Feb 18, 2025
| @@ -46,6 +46,11 @@ namespace isobus | |||
| return controlFunctionNAME; | |||
| } | |||
|
|
|||
| void ControlFunction::set_NAME(const NAME &newNAME) | |||
| { | |||
| controlFunctionNAME = newNAME; | |||
There was a problem hiding this comment.
What's the intent of this setter? IDK if we would want it exposed to everything, because if it's called on an internal control function it will not restart address claiming or anything....
There was a problem hiding this comment.
I used this to alter the NAME of the CF here, right after it's initialization:
https://github.com/martonmiklos/AgIsoVirtualTerminal/blob/support_setting_vt_number/src/ServerMainComponent.cpp#L51
What do you think if I move all the settings handling in AgIsoVT to a separate class what I can initialize before the creation of the ServerMainComponent handle the CF Name change before the CF initialization. This way we can get rid from this change in the stack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added infrastructure for VT number handling and VT number identification. This includes:
Fixes Open-Agriculture/AgIsoVirtualTerminal/#81
How has this been tested?
Built AgIsoVT supporting the setting of the VT number using this stack