Merge branch 'master' into alpha

Open-Attestation · Sep 28, 2023 · d2e9b97 · d2e9b97
2 parents b1e6542 + db4c3ec
commit d2e9b97
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/components/common/RedactableValue.test.tsx b/src/components/common/RedactableValue.test.tsx
@@ -91,4 +91,16 @@ describe("redactablevalue component", () => {
     render(<RedactableValue value={`foo`} isValueHidden onRedactionRequested={callback} editable />);
     expect(screen.queryByTestId("redactable-value")).not.toBeInTheDocument();
   });
+
+  it("should show redact handler when value exists", () => {
+    const callback = jest.fn();
+    render(<RedactableValue value={`foo`} onRedactionRequested={callback} editable />);
+    expect(screen.queryByTitle("Redact handler")).toBeInTheDocument();
+  });
+
+  it("should not show redact handler when value does not exists (obfuscated)", () => {
+    const callback = jest.fn();
+    render(<RedactableValue onRedactionRequested={callback} editable />);
+    expect(screen.queryByTitle("Redact handler")).not.toBeInTheDocument();
+  });
 });
diff --git a/src/components/common/RedactableValue.tsx b/src/components/common/RedactableValue.tsx
@@ -69,7 +69,7 @@ export const RedactableValue: FunctionComponent<RedactValueProps> = ({
           {getMessage()}
         </span>
       )}
-      {editable && (
+      {editable && value && (
         <span
           title="Redact handler"
           className={`inline-block cursor-pointer ${className}`}