Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove css loader and imports #141

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

chershentan
Copy link
Contributor

Summary

The PR from #135
broke a downstream NextJS build.

This is due to NextJS, Global CSS cannot be imported from within node modules.

Changes

  • Directly embed the required css into pdfRenderer
  • remove the css imports
  • remove css-loader and style-loader from webpack config.

Issues

What are the related issues or stories?

@chershentan chershentan merged commit 075d39e into master May 31, 2024
1 check passed
Copy link

🎉 This PR is included in version 3.17.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 3.16.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants