Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: migrate to github actions #45

Merged
merged 3 commits into from
Oct 27, 2023
Merged

ci: migrate to github actions #45

merged 3 commits into from
Oct 27, 2023

Conversation

superical
Copy link
Contributor

This PR migrates the existing Circle CI pipeline to use Github Actions.

@superical
Copy link
Contributor Author

@Open-Attestation/maintainers For review.

Copy link
Member

@HJunyuan HJunyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @superical! 🚀

Btw we should upgrade from Node v14 -> v18 soon

@HJunyuan
Copy link
Member

Can disconnect/remove this repo from the CircleCI dashboard so we won't have a failing check here

@superical superical closed this Oct 27, 2023
@superical superical reopened this Oct 27, 2023
@superical
Copy link
Contributor Author

Can disconnect/remove this repo from the CircleCI dashboard so we won't have a failing check here

I have removed it. For some reason, this PR still appears to have that CircleCI check. I believe the subsequent one shouldn't have the CircleCI pipeline anymore. I'll test it too.

@superical superical merged commit f421823 into master Oct 27, 2023
10 of 11 checks passed
@superical superical deleted the ci/migrate-ci branch October 27, 2023 07:28
@superical
Copy link
Contributor Author

@HJunyuan Ok good, the CircleCI doesn't appear anymore. Tested in #46.

image

Copy link

🎉 This PR is included in version 2.6.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants