Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: verifier issuer check contract exists #84

Merged
merged 4 commits into from
Feb 5, 2020

Conversation

Nebulis
Copy link
Contributor

@Nebulis Nebulis commented Jan 17, 2020

  • handle address promise on contract directly so that no uncaught error is thrown anymore
  • added reason for invalid / error cases, containing a message and a code => should we remove message ?
  • added 3 new reasons

@Nebulis Nebulis force-pushed the feat/verifier-contract-exists-v2 branch 2 times, most recently from 214745f to 882e618 Compare January 21, 2020 05:12
@Nebulis Nebulis force-pushed the feat/verifier-contract-exists-v2 branch 5 times, most recently from d423279 to 4ca6b57 Compare January 21, 2020 08:57
@Nebulis Nebulis force-pushed the feat/verifier-contract-exists-v2 branch from 4ca6b57 to ca576b3 Compare January 21, 2020 09:04
@Nebulis
Copy link
Contributor Author

Nebulis commented Jan 22, 2020

resolves #69

@Nebulis Nebulis requested a review from rjchow January 22, 2020 03:12
@Nebulis Nebulis merged commit 61406e8 into master Feb 5, 2020
@Nebulis Nebulis deleted the feat/verifier-contract-exists-v2 branch February 5, 2020 10:18
@john-dot-oa
Copy link
Contributor

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants