Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added typeRoots #190

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: added typeRoots #190

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
068b431
chore: added typeRoots
eugbyte Jun 29, 2021
d954aa9
chore: dist
eugbyte Jun 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"moduleResolution": "node",
"strict": true,
"baseUrl": ".",
"typeRoots": ["./src/@types", "./node_modules/@types"],
"typeRoots": ["./src/@types", "./src/shared/@types", "./node_modules/@types"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can remove src/@types

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, this solution still does not work.

In open-attestation-cli's package.json,

"@govtechsg/open-attestation": "github:eugbyte/open-attestation#experiment/types",

Will have to resolve it by creating our own documentLoader. as you suggested

"skipLibCheck": true,
"resolveJsonModule": true,
"esModuleInterop": true
Expand Down