-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update path for schema #259
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
72c116e
fix: update path for schema
zixiang2018 fd3fca3
fix: use path join
zixiang2018 2e64e94
chore: use postbuild
zixiang2018 80b5635
chore: lint
zixiang2018 49ed82c
chore: use prebuild
zixiang2018 c1565ed
fix: add run build to get schema for test
zixiang2018 5b26e8d
chore: run prebuild script
zixiang2018 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
/* eslint-disable @typescript-eslint/no-var-requires */ | ||
const fs = require("fs"); | ||
const path = require("path"); | ||
const standaloneCode = require("ajv/dist/standalone").default; | ||
const Ajv = require("ajv"); | ||
const { clone, cloneDeepWith } = require("lodash"); | ||
|
||
const openAttestationSchemav2 = require(path.join(process.cwd(), "src/2.0/schema/schema.json")); | ||
const openAttestationSchemav3 = require(path.join(process.cwd(), "src/3.0/schema/schema.json")); | ||
|
||
// remove enum and pattern from the schema | ||
function transformSchema(schema) { | ||
const excludeKeys = ["enum", "pattern"]; | ||
function omit(value) { | ||
if (value && typeof value === "object") { | ||
const key = excludeKeys.find((key) => value[key]); | ||
if (key) { | ||
const node = clone(value); | ||
excludeKeys.forEach((key) => { | ||
delete node[key]; | ||
}); | ||
return node; | ||
} | ||
} | ||
} | ||
|
||
const newSchema = cloneDeepWith(schema, omit); | ||
// because we remove check on enum (DNS-DID, DNS-TXT, etc.) the identity proof can match multiple sub schema in v2. | ||
// so here we change oneOf to anyOf, so that if more than one identityProof matches, it still passes | ||
if (newSchema?.definitions?.identityProof?.oneOf) { | ||
newSchema.definitions.identityProof.anyOf = newSchema?.definitions?.identityProof?.oneOf; | ||
delete newSchema?.definitions?.identityProof?.oneOf; | ||
} | ||
return newSchema; | ||
} | ||
|
||
console.log('"Creating strict compiled schema for v2 and v3"'); | ||
const addFormats = require("ajv-formats").default; | ||
|
||
let strictAjv = new Ajv({ | ||
allErrors: true, | ||
allowUnionTypes: true, | ||
schemas: [openAttestationSchemav2, openAttestationSchemav3], | ||
code: { source: true }, | ||
}).addKeyword("deprecationMessage"); | ||
addFormats(strictAjv); | ||
|
||
fs.writeFileSync(path.join(__dirname, "../src/__generated__/compiled_schema_strict.js"), standaloneCode(strictAjv)); | ||
|
||
console.log('"Creating non-strict compiled schema for v2 and v3"'); | ||
// custom ajv for loose schema validation | ||
// it will allow invalid format, invalid pattern and invalid enum | ||
let nonStrictAjv = new Ajv({ | ||
allErrors: true, | ||
allowUnionTypes: true, | ||
schemas: [transformSchema(openAttestationSchemav2), transformSchema(openAttestationSchemav3)], | ||
code: { source: true }, | ||
validateFormats: false, | ||
}).addKeyword("deprecationMessage"); | ||
addFormats(nonStrictAjv); | ||
|
||
fs.writeFileSync( | ||
path.join(__dirname, "../src/__generated__/compiled_schema_non_strict.js"), | ||
standaloneCode(nonStrictAjv) | ||
); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be clear,
prebuild
should automatically run whennpm run build
is triggered. But since we don't build before running our tests, I understand we have to manually call it hereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup! Didnt wanted to add a
npm run build
in here because its not needed by the test script