chore: rename securing mechanism to OpenAttestationHashProof2018 #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cxcheng
changed the title
HJunyuan
changed the title
HJunyuan
force-pushed
the
chore/rename-to-OpenAttestationHashProof2018
branch
from
2c18ece to
0417f06
Compare
phanshiyu
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The name change is to be done before OA v4 rollout. The reason is that the team feels that the original name of OpenAttestationMerkleProofSignature2018 does not correctly reflect that we are not using a Merkle Tree structure within a document. We are only doing it for a batch of OA documents. We feel we want to more accurately reflect this in our communications with the external world, particularly the W3C.
Changes
Only changes done is a global search and replace of OpenAttestationMerkleProofSignature2018 to OpenAttestationHashProof2018.
Issues
None