Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow both OA and W3C VCs to be digested or signed #317

Open
wants to merge 4 commits into
base: beta
Choose a base branch
from

Conversation

HJunyuan
Copy link
Member

@HJunyuan HJunyuan commented Nov 19, 2024

What does this PR do?

This PR will introduce breaking changes to OA v4 (which is currently in beta).

  1. Allow both OA and W3C VCs to be digested or signed
  2. Use "digest" terminology instead of "wrap"
  3. signVc() will automatically digest before performing signing. As such, digest and sign are now separate processes
    1. signVc() will not re-sign if proof object is already defined
  4. digestVc() is left available for use with Ethereum issuance
  5. Stop grouping or the usage of any shared functions/utils between v2 and v4 (e.g. src/index.ts)
    1. In future, those functions will only serve v2 once v3 has been removed
  6. Rename all remaining mention of document to vc

@HJunyuan HJunyuan changed the base branch from master to beta November 19, 2024 04:17
@HJunyuan HJunyuan marked this pull request as ready for review December 3, 2024 06:31
@HJunyuan HJunyuan changed the title feat: allow both OA and W3C VCs to be digested or signing feat: allow both OA and W3C VCs to be digested or signed Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant