ci: migrate to github actions #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superical
approved these changes
Jul 19, 2024
|
🎉 This PR is included in version 1.21.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
superical
reviewed
Jul 19, 2024
Comment on lines
+33
to
+34
| - name: Validate PR commits with commitlint | ||
| run: npx commitlint --from ${{ github.event.pull_request.base.sha }} --to ${{ github.event.pull_request.head.sha }} --verbose |
There was a problem hiding this comment.
Since we squash most of our PRs, should we commit lint the title of the PR instead of the individual commits, which will be squashed anyway? The title of the PR will be the committed name that will eventually be on the actual history.😅
I think we can keep what you have. If we want to lint the PR title, we can make use of github.event.pull_request.title and pass it to commitlint.
There was a problem hiding this comment.
Oops... I just realise this PR has been merged. It's ok, just a small thing. haha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrate from CircleCI to GitHub Actions workflow