Few tf fixes/improvements #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kamoppl
force-pushed
the
kamilg/update_tf_dec
branch
from
81b9660 to
8ffb7a1
Compare
katlapinka
previously approved these changes
Dec 16, 2024
Deixx
reviewed
Dec 30, 2024
| TestRun.executor.disconnect() | ||
| TestRun.executor.wait_for_connection(timedelta(seconds=TestRun.dut.virsh["reboot_timeout"])) | ||
| self.executor.run_expect_success( | ||
| f"(sleep {delay_until_reboot} && " f"sudo virsh start {TestRun.dut.virsh['vm_name']}) &" |
There was a problem hiding this comment.
Suggested change
| f"(sleep {delay_until_reboot} && " f"sudo virsh start {TestRun.dut.virsh['vm_name']}) &" | |
| f"(sleep {delay_until_reboot} && sudo virsh start {TestRun.dut.virsh['vm_name']}) &" |
| raise ValueError(f"Virsh power plugin error: couldn't find VM {vm_name} on host " | ||
| f"{self.host}") | ||
| raise ValueError( | ||
| f"Virsh power plugin error: couldn't find VM {vm_name} on host " f"{self.host}" |
There was a problem hiding this comment.
Suggested change
| f"Virsh power plugin error: couldn't find VM {vm_name} on host " f"{self.host}" | |
| f"Virsh power plugin error: couldn't find VM {vm_name} on host {self.host}" |
added 3 commits
January 2, 2025 01:36
Signed-off-by: Kamil Gierszewski <[email protected]>
Signed-off-by: Kamil Gierszewski <[email protected]>
Signed-off-by: Kamil Gierszewski <[email protected]>
Kamoppl
force-pushed
the
kamilg/update_tf_dec
branch
from
8ffb7a1 to
3374881
Compare
katlapinka
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.