[cbuild2cmake] Fix executes with always tag not creating CMake outputs #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correctly define output files of executes statements with always tag so that dependent executes statements have correct CMake dependencies. Otherwise the build breaks due to missing rules to make the dependencies. Fixes Open-CMSIS-Pack#208.
EaselinkBachmann
force-pushed
the
feature/fix-always-byproducts
branch
from
249143c to
3a0f8b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the generated
add_custom_target()statements to correctly define output files of executes statements withalways:tag so that dependent executes statements have correct CMake dependencies. Otherwise the build breaks due to missing rules to make the dependencies.Fixes #208.