-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test for online connection #222
Conversation
Code Climate has analyzed commit 57529b5 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 35.6% (50% is the threshold). This pull request will bring the total coverage in the repository to 81.7% (-2.0% change). View more on Code Climate. |
… not recognized by coverage tool (TODO)" This reverts commit 0455a54.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check linter findings
Error: ST1003: var wrongUrlPath should be wrongURLPath (stylecheck)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wird das "noCLeanup" im TestCase struct nicht gesetzt? Zumindest habe ich nur eine Benutzung gesehen.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
see #219