Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for online connection #222

Merged
merged 14 commits into from
Nov 13, 2023
Merged

Test for online connection #222

merged 14 commits into from
Nov 13, 2023

Conversation

thorstendb-ARM
Copy link
Collaborator

@thorstendb-ARM thorstendb-ARM commented Nov 3, 2023

see #219

@thorstendb-ARM thorstendb-ARM requested a review from bgn42 November 3, 2023 13:08
Copy link

codeclimate bot commented Nov 6, 2023

Code Climate has analyzed commit 57529b5 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 35.6% (50% is the threshold).

This pull request will bring the total coverage in the repository to 81.7% (-2.0% change).

View more on Code Climate.

Copy link
Collaborator

@soumeh01 soumeh01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check linter findings
Error: ST1003: var wrongUrlPath should be wrongURLPath (stylecheck)

bgn42
bgn42 previously approved these changes Nov 6, 2023
Copy link
Collaborator

@bgn42 bgn42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wird das "noCLeanup" im TestCase struct nicht gesetzt? Zumindest habe ich nur eine Benutzung gesehen.

@thorstendb-ARM
Copy link
Collaborator Author

Wird das "noCLeanup" im TestCase struct nicht gesetzt? Zumindest habe ich nur eine Benutzung gesehen.
This is always "false" (default), and is currently just required for one test case as preperation.

soumeh01
soumeh01 previously approved these changes Nov 7, 2023
Copy link
Collaborator

@soumeh01 soumeh01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thorstendb-ARM thorstendb-ARM merged commit 49b7939 into main Nov 13, 2023
12 of 16 checks passed
@thorstendb-ARM thorstendb-ARM deleted the connTest branch November 13, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants