Fix code scanning alert no. 50: Disabled TLS certificate check #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
bgn42
reviewed
Nov 18, 2024
|
I guess so. We could define a default location and filename for self-signed certificate, if I understand this correctly, or we simply bail out but would not be able to run tests locally easily. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/Open-CMSIS-Pack/cpackget/security/code-scanning/50
To fix the problem, we should avoid setting
InsecureSkipVerifytotrueeven for localhost connections. Instead, we can configure the application to use a self-signed certificate for local development and testing. This way, we maintain the security of TLS connections without disabling certificate verification.http.Transportto use this certificate for connections to127.0.0.1.DownloadFilefunction to load and use the self-signed certificate when connecting to127.0.0.1.Suggested fixes powered by Copilot Autofix. Review carefully before merging.