Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index pidx load #394

Merged
merged 12 commits into from
Dec 5, 2024
Merged

Index pidx load #394

merged 12 commits into from
Dec 5, 2024

Conversation

bgn42
Copy link
Collaborator

@bgn42 bgn42 commented Dec 3, 2024

Fixes

Changes

Automagically load of index.pidx

  • 355, 357, 358

Checklist

  • 🤖 This change is covered by unit tests as required.
  • 🤹 All required manual testing has been performed.
  • 🛡️ Security impacts have been considered.
  • 📖 All documentation updates are complete.
  • 🧠 This change does not change third-party dependencies

@bgn42 bgn42 requested a review from jkrech December 3, 2024 23:53
cmd/commands/init_test.go Outdated Show resolved Hide resolved
cmd/errors/errors.go Outdated Show resolved Hide resolved
cmd/errors/errors.go Outdated Show resolved Hide resolved
cmd/errors/errors.go Outdated Show resolved Hide resolved
cmd/installer/root.go Show resolved Hide resolved
cmd/commands/update_index.go Outdated Show resolved Hide resolved
@jkrech jkrech self-requested a review December 4, 2024 16:43
jkrech
jkrech previously approved these changes Dec 4, 2024
Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

… .Web uppercase W, suppress unused zip warning
jkrech
jkrech previously approved these changes Dec 5, 2024
Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codeclimate bot commented Dec 5, 2024

Code Climate has analyzed commit 9d45f7b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 51.3% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.5% (-0.2% change).

View more on Code Climate.

@jkrech jkrech self-requested a review December 5, 2024 18:24
Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkrech jkrech merged commit ceff869 into main Dec 5, 2024
18 of 19 checks passed
@jkrech jkrech deleted the IndexPidxLoad branch December 5, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants