Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use update cfg #410

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Use update cfg #410

merged 3 commits into from
Dec 16, 2024

Conversation

bgn42
Copy link
Collaborator

@bgn42 bgn42 commented Dec 16, 2024

Fixes

  • use update.cfg instead of index.pidx timestamp
  • do not update with rm and list
  • corrected tests

Changes

Checklist

  • 🤖 This change is covered by unit tests as required.
  • 🤹 All required manual testing has been performed.
  • 🛡️ Security impacts have been considered.
  • 📖 All documentation updates are complete.
  • 🧠 This change does not change third-party dependencies

Copy link

codeclimate bot commented Dec 16, 2024

Code Climate has analyzed commit 948a086 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 7.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.8% (-0.8% change).

View more on Code Climate.

@bgn42 bgn42 requested a review from jkrech December 16, 2024 11:51
@jkrech jkrech requested a review from brondani December 16, 2024 12:00
Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmd/installer/root.go Show resolved Hide resolved
cmd/installer/root.go Show resolved Hide resolved
@bgn42 bgn42 merged commit ef80bf9 into main Dec 16, 2024
18 of 19 checks passed
@bgn42 bgn42 deleted the useUpdateCfg branch December 16, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants