Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpackget] Retry download without User-Agent header #413

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

brondani
Copy link
Collaborator

@brondani brondani commented Dec 18, 2024

Fixes

Changes

  • Resend the HTTP GET request without user agent header when the first attempt with User-Agent: cpackget/v<version> fails with status code StatusNotFound

Checklist

  • 🤖 This change is covered by unit tests as required.
  • 🤹 All required manual testing has been performed.
  • 🛡️ Security impacts have been considered.
  • 📖 All documentation updates are complete.
  • 🧠 This change does not change third-party dependencies

Copy link

codeclimate bot commented Dec 18, 2024

Code Climate has analyzed commit 6c046ef and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 62.5% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.9% (0.1% change).

View more on Code Climate.

@brondani brondani marked this pull request as ready for review December 18, 2024 10:05
@brondani brondani requested review from jkrech and bgn42 December 18, 2024 10:06
Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
validated the build running:
cpackget add NXP::[email protected]
The pack is not installed successfully

@jkrech jkrech merged commit 2edf433 into main Dec 18, 2024
19 checks passed
@jkrech jkrech deleted the cpackget-retry-request-without-useragent branch December 18, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants