Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for property filters #767

Merged
merged 9 commits into from
Apr 30, 2024
Merged

add tests for property filters #767

merged 9 commits into from
Apr 30, 2024

Conversation

bossie
Copy link
Collaborator

@bossie bossie commented Apr 29, 2024

Part of #460.

@bossie bossie linked an issue Apr 29, 2024 that may be closed by this pull request
@bossie
Copy link
Collaborator Author

bossie commented Apr 30, 2024

@soxofaan,

I'm trying to address this TODO here but can't seem to find the way to implement it:

# TODO: check if only items that match this property are included,
# e.g. with calls to org.openeo.opensearch.OpenSearchResponses.featureBuilder().withId("item01")

What the test does is pass a property filter ("season" == "s1") to load_stac so only STAC Item "item01" is loaded ("item02" doesn't have this "season" property).

To this end, I'm trying to see if (in pseudocode) org.openeo.geotrellis.file.FixedFeaturesOpenSearchClient().addFeature() is called exactly once with Feature("item01"):

opensearch_client.addFeature(f)

Some guidance?

@bossie bossie marked this pull request as ready for review April 30, 2024 13:56
@bossie bossie merged commit 286aff2 into master Apr 30, 2024
1 check passed
@bossie bossie deleted the 460_property_filters branch April 30, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

integrate CLMS HRL VPP
1 participant