Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for apply_vectorcube udf #856 #882

Conversation

JeroenVerstraelen
Copy link
Contributor

No description provided.

@JeroenVerstraelen
Copy link
Contributor Author

Related PR in python-client:
Open-EO/openeo-python-client#631

@JeroenVerstraelen
Copy link
Contributor Author

Related PR in openeo-python-driver:
https://github.com/Open-EO/openeo-python-driver/pull/314/files

tests/test_vectorcube.py Outdated Show resolved Hide resolved
tests/test_vectorcube.py Outdated Show resolved Hide resolved
@soxofaan
Copy link
Member

after reviewing the other PRs in python client and python driver: do we actually need this #882 that adds a test in geopyspark driver actually? All functionality is actually elsewhere: python client and python driver, so the tests should be there

@JeroenVerstraelen
Copy link
Contributor Author

after reviewing the other PRs in python client and python driver: do we actually need this #882 that adds a test in geopyspark driver actually? All functionality is actually elsewhere: python client and python driver, so the tests should be there

The test in the geopyspark driver is specifically to see if you can apply an udf on the output of raster_to_vector without any issues. Because previously that didn't work as expected.

@soxofaan
Copy link
Member

ah ok indeed, raster_to_vector is the differentiating aspect here

@soxofaan
Copy link
Member

soxofaan commented Sep 26, 2024

Also to include in this PR: as it depends on python client and python driver changes, it should bump the version constraint of these dependencies in setup.py
Which implies you should also bump the versions in

@JeroenVerstraelen
Copy link
Contributor Author

All comments should be addressed now except for the extra tests in the python driver and client, those will be handled in this issue:
Open-EO/openeo-python-driver#315

@JeroenVerstraelen JeroenVerstraelen merged commit 5ed1e57 into master Sep 26, 2024
@JeroenVerstraelen JeroenVerstraelen deleted the 881-apply_vectorcubegeometries-cube-udf-for-vectorcubes branch September 26, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apply_vectorcube(geometries, cube) udf for VectorCubes
2 participants