revert assert_batch_job helper

[soxofaan]

openeo-geopyspark-integrationtests/tests/test_integration.py

Lines 70 to 73 in 6a2a65e

	def assert_batch_job(job: BatchJob, assertion: bool, extra_message: str = ""):
	try:
	assert assertion
	except AssertionError as e:

@JeroenVerstraelen you added assert_batch_job to simplify debugging integration tests I guess, but I think that this helper actually makes post-mortem investigation harder.

It's important to understand how pytest handles and report assert failures. If you use something like assert "foo" == "bar" in a test, pytest will clearly print both the values ("foo" and "bar") in the test failure report, which is extremely useful for debugging failed tests. (Note that pytest does quite a bit of magic behind the screens to make this possible)

If you replace that with a helper construct like

def assert_this(condition):
    assert condition

def test_foo()
    x = "f" + ("o" * 2)
    assert_this(x == "bar")

you lose this unique selling point of pytest as you will only see something like "assert False" in the test report, without any pointers to the actual values that were compared ("foo" and "bar" here)

I think we should revert introducing that assert_batch_job helper

[soxofaan]

I managed to get logging logs included in the junit report, which reduces the need for that assertion message generation of assert_batch_job (I guess it was added to automatically see the job id)

[soxofaan]

Related: I noticed this other helper execute_batch_with_error_logging but I'm not sure if there is much added value (especially if assert_batch_job would be eliminated)

[JeroenVerstraelen]

I'm a bit late in my response but I agree that we should remove assert_batch_job.

[soxofaan]

Also note that this helper exposes internal (kibana) urls in this open source repo