Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mask and fix resample_cube_spatial #165

Merged
merged 23 commits into from
Jan 2, 2024

Conversation

clausmichele
Copy link
Member

@clausmichele clausmichele commented Sep 29, 2023

Overview of this PR:

  1. Implementation of the mask process, supporting auto resampling (using resample_cube_spatial)
  2. Tests for mask
  3. Improvements of resample_cube_spatial, fixing [BUG] resample_cube_spatial fails if dimensions are not matching #191
  4. Tests for resample_cube_spatial
  5. Now resample_spatial is correctly imported, solving this: feat: Implementation of resample_spatial to reproject values #103 (comment)
  6. Moved resample_cube_spatial out of experimental, since it's necessary within the mask process.

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (8d9e3fb) 79.42% compared to head (1ec6eeb) 81.79%.

❗ Current head 1ec6eeb differs from pull request most recent head 1a20282. Consider uploading reports for the commit 1a20282 to get more accurate results

Files Patch % Lines
...ocesses_dask/process_implementations/cubes/mask.py 85.93% 9 Missing ⚠️
...ses_dask/process_implementations/cubes/resample.py 84.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
+ Coverage   79.42%   81.79%   +2.36%     
==========================================
  Files          30       29       -1     
  Lines        1468     1450      -18     
==========================================
+ Hits         1166     1186      +20     
+ Misses        302      264      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clausmichele
Copy link
Member Author

There's something wrong with the code, the commits are messed up. I will fix it.

@ValentinaHutter
Copy link
Collaborator

Nice work! As the codecov already suggests, it would be good to have some tests in place! :)

@clausmichele clausmichele changed the title feat: add mask feat: add mask and fix resample_cube_spatial Nov 9, 2023
@clausmichele
Copy link
Member Author

@ValentinaHutter @GeraldIr I updated the PR, now it contains fixes for resample_cube_spatial and resample_spatial, along with the mask implementation. Check the first comment where I explain the content.

Copy link
Member

@GeraldIr GeraldIr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, sorry for the delay on approving this, just got back from holidays.

@GeraldIr GeraldIr merged commit 4a011c4 into Open-EO:main Jan 2, 2024
3 checks passed
@clausmichele clausmichele deleted the mask branch May 22, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants