-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add mask and fix resample_cube_spatial #165
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #165 +/- ##
==========================================
+ Coverage 79.42% 81.79% +2.36%
==========================================
Files 30 29 -1
Lines 1468 1450 -18
==========================================
+ Hits 1166 1186 +20
+ Misses 302 264 -38 ☔ View full report in Codecov by Sentry. |
There's something wrong with the code, the commits are messed up. I will fix it. |
Nice work! As the codecov already suggests, it would be good to have some tests in place! :) |
@ValentinaHutter @GeraldIr I updated the PR, now it contains fixes for resample_cube_spatial and resample_spatial, along with the mask implementation. Check the first comment where I explain the content. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, sorry for the delay on approving this, just got back from holidays.
Overview of this PR:
mask
process, supporting auto resampling (usingresample_cube_spatial
)mask
resample_cube_spatial
, fixing [BUG]resample_cube_spatial
fails if dimensions are not matching #191resample_cube_spatial
resample_spatial
is correctly imported, solving this: feat: Implementation of resample_spatial to reproject values #103 (comment)resample_cube_spatial
out of experimental, since it's necessary within themask
process.