-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter spatial #170
Filter spatial #170
Conversation
Codecov Report
@@ Coverage Diff @@
## main #170 +/- ##
==========================================
+ Coverage 80.12% 80.24% +0.11%
==========================================
Files 29 30 +1
Lines 1268 1382 +114
==========================================
+ Hits 1016 1109 +93
- Misses 252 273 +21
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This PR includes implementations of filter_spatial and mask_polygon. We tested them on full S2 tiles, you also may need to test them on the EODC back-end and report if you see some issues. Current implementation supports only geoJSON vector-cubes, since currently the |
From this PR: Open-EO#170
@ValentinaHutter @GeraldIr can you start reviewing this PR? We would need them for the demo at BIDS! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one question about unused variables, but that doesn't seem to impact the logic of the function, otherwise LGTM!
@GeraldIr @ValentinaHutter I think it would be good to test the implementation at EODC with your cluster and with your data, to check how it behaves with large datasets. |
Hi team,
together with @clausmichele have implemented spatial_filter process and added a test for it.