Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support date-only, add TemporalExtentEmpty exception #211

Merged
merged 6 commits into from
Sep 16, 2024

Conversation

m-mohr
Copy link
Member

@m-mohr m-mohr commented Dec 14, 2023

  • Support date-only
  • check whether the temporal extent is empty

Found by the new test suite and want to make you aware. I won't have time to add tests, this is more a bug report rather than a full PR.

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (8d9e3fb) 79.42% compared to head (737feb3) 79.33%.

Files Patch % Lines
...sses_dask/process_implementations/cubes/_filter.py 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
- Coverage   79.42%   79.33%   -0.10%     
==========================================
  Files          30       30              
  Lines        1468     1476       +8     
==========================================
+ Hits         1166     1171       +5     
- Misses        302      305       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ValentinaHutter ValentinaHutter merged commit 1091de5 into main Sep 16, 2024
2 checks passed
@ValentinaHutter ValentinaHutter deleted the filter_temporal branch September 16, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants