-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added pattern for list_collections #382
base: master
Are you sure you want to change the base?
Conversation
I'm a bit hesitant to this, as a user might want more flexibility than what the current PR allows: e.g. filter strictly on prefix/suffix, exclude instead of include, use a regex instead of single string, check multiple patterns at same time, ... What might make more sense is to make Also, a user might want to filter on other fields than just |
Indeed, this PR was just an idea that we can discuss about and that could evolve in different ways. I do consider this metadata filtering as something to tackle as possible new developments. |
when generalized in some way, this feature could also be useful in the context of:
|
fyi: In the Jupyter interface there's already a search control for the Vue components :-) |
I know, but sometimes it would be good to avoid user interactions and show directly what we would like to! So, if an example is focused on Sentinel-2, instead of writing "please type Sentinel-2 to filter the collections", we can just present them the available ones given a keyword. |
Sentinel 2 is a good example for an implementation, because it should likely match "Sentinel2", "Sentinel 2", "Sentinel-2", "Sentinel_2" and "Sentinel 2A". And you may want to match it in ID, title and maybe even more (keywords, description?). Thus the code must do some normalization, which for example leads to quite a bit of code in the Vue components: https://github.com/Open-EO/openeo-vue-components/blob/master/utils.js#L434 |
@soxofaan I was considering that it could be useful to have the ability to filter the collections directly by providing a keyword/pattern when calling list_collections(). What do you think?