localprocessing updates

[clausmichele]

This PR contains:

• added the implementation of resample_cube_spatial based on xArray, since the one in openeo-processes-dask based on opendatacube relies on metadata provided only when the data comes from ODC
• added two example notebooks
• updated the minimum required library versions

[soxofaan]

some quick notes

[soxofaan]

Not to be fixed in this PR, but I noticed that this logo looks quite ragged. I think we should host a proper version of the logo somewhere

[soxofaan]

why this <3.11 constraint?

[clausmichele]

Comes from here: https://github.com/Open-EO/openeo-processes-dask/blob/6563c1809fc4108581b78763a970b3bea1d5d935/pyproject.toml#L25

@LukeWeidenwalker how could I help to test more Python versions? It would be good to add 3.11 at least.

[LukeWeidenwalker]

When I initially set up the repo, I put 3.9, 3.10 and 3.11 in the CI matrix for github actions. 3.11 failed for a reason that I can't recall now, and since our backend runs on 3.9, I've just ignored it since. Would be in favor of becoming 3.11 compatible though! I'd start by including 3.11 in the matrix here: https://github.com/Open-EO/openeo-processes-dask/blob/main/.github/workflows/main.yml in a new PR and just seeing what breaks. Once the build passes, we can remove this constraint!

[soxofaan]

don't call a dictionary a list, that's quite confusing

also: where do these int values come from, is that ad-hoc, or is that defined somewhere?

[clausmichele]

They come from the rioxarray - rasterio docs:

https://corteva.github.io/rioxarray/stable/rioxarray.html#rioxarray.raster_array.RasterArray.reproject_match
https://rasterio.readthedocs.io/en/stable/api/rasterio.enums.html#id0

Should I include the link in the code as a comment?

[soxofaan]

I would then use the enum attributes directly, something like

    "near": rasterio.enums.Resampling.nearest
    ...

[clausmichele]

Done

[soxofaan]

also note that that rasterio enum can handle the mapping itself, so I don't think you need your own:

>>> import rasterio.enums
>>> rasterio.enums.Resampling(5)
<Resampling.average: 5>
>>> rasterio.enums.Resampling(4).name
'lanczos'
>>> rasterio.enums.Resampling["gauss"].value
7

[clausmichele]

I created this mapping since in openEO we have "near" instead of "nearest" and "cubicspline" instead of "cubic_spline"

[soxofaan]

then I would just translate these minor differences, but let rasterio.enums.Resampling do the heavy lifting, e.g.

method = {
    "near": "nearest",
    "cubicspline": "cubic_spline"
}.get(method, method)
try:
    resampling = rasterio.enums.Resampling[method]
except KeyError:
    ValueError(
            f'Selected resampling method not available.... select one of {[r.name for r in rasterio.enums.Resampling]}" ...

[clausmichele]

Fine. However, if we raise that ValueError, we would list nearest and cubic_spline as allowed resampling methods, that if used in a process graph would make it invalid if there's some validation mechanism in place.

[clausmichele]

@soxofaan I think that this is the last point open before being able to merge. Can we agree on my latest version?

[soxofaan]

merged

(FYI did some post-merge cleanups in fbf69e6 , including removal of unused input_data_dims which you might want to double check)