Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #259 Make pyproj an optional dependency when parsing CRS strin… #458

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

JohanKJSchreurs
Copy link
Contributor

Issue #259 continued: Make pyproj an optional dependency when parsing CRS string / EPSG code

  • Now the import of pyproj happens locally in the function that needs it.
  • CRS values are only processed further with pyproj when they are neither type int nor a string that represents an integer.

@soxofaan soxofaan merged commit 3609c78 into master Aug 9, 2023
16 checks passed
@soxofaan soxofaan deleted the issue259_part2-make-pyproj-an-optional-dependency branch August 9, 2023 14:22
@soxofaan
Copy link
Member

soxofaan commented Aug 9, 2023

thanks,
merged already to get builds working again

(If necessary, I'll do some follow-ups directly on master)

@soxofaan
Copy link
Member

soxofaan commented Aug 9, 2023

did some refactoring in the end in b2a0e00 (tagged this ticket wrong apparently).
Biggest change is that the normalization function also can return a WKT2 CRS string (not only EPSG int), because that is also allowed in openEO API. This made it actually possible to simplify the function and rework the optional pyproj import stuff

soxofaan added a commit that referenced this pull request Aug 9, 2023
Skip based on pyproj version iso python version
(allows testing the skips on higher python versions too)
@soxofaan
Copy link
Member

soxofaan commented Aug 9, 2023

pff that pyproj stuff is highly version sensitive. It took more commits that I anticipated to get things right. I should have worked in a feature branch in hindsight 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants