Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define a new udf signature to separate metadata from data transformation #463

Merged
merged 3 commits into from
Sep 7, 2023

Conversation

jdries
Copy link
Collaborator

@jdries jdries commented Aug 23, 2023

Separating metadata transformation allows process graph analysis to work better when UDF's perform more complex transformations.
One example was requested in this issue:
Open-EO/openeo-geopyspark-driver#412

Applies for instance to UDF's that:

  • change band labels
  • change spatial resolution
  • change crs of spatial dimension
  • change timestamps on temporal dimension

I requested some reviews as this is an extension of the UDF API. It's a non-breaking change, UDF's that work will continue to work.
@m-mohr I'll want to make this an agenda topic on one of the next dev meetings. Do we require PSC approval for changes to UDF API?

@LukeWeidenwalker
Copy link

At EODC we do not support UDFs right now and it's currently not on our roadmap, so nothing to comment on from my side! (maybe @christophreimer has something to add)

@m-mohr
Copy link
Member

m-mohr commented Aug 23, 2023

@jdries Added to the agenda for September, @clausmichele is leading it in Sept.

The PSC guideslines are not overly clear on this: "Anything that could cause backward compatibility issues in normative specifications (e.g., API or process specifications)." Is the UDF API a normative specification? :-) But I'd say it doesn't hurt to at least present the anticipated changes there. Next PSC meeting is in October.

Edit: Nevermind, it's a non-breaking change so can just be merged, I think.

Copy link
Member

@soxofaan soxofaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

openeo/udf/udf_signatures.py Outdated Show resolved Hide resolved
openeo/udf/udf_signatures.py Outdated Show resolved Hide resolved
@jdries jdries merged commit ba27981 into master Sep 7, 2023
15 checks passed
@jdries jdries deleted the udf_apply_metadata branch September 7, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants