Skip to content

Commit

Permalink
fixup! Issue #114/#200 support promoting feature properties to cube v…
Browse files Browse the repository at this point in the history
…alues
  • Loading branch information
soxofaan committed Aug 3, 2023
1 parent c2842ed commit 4bdd41f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion openeo_driver/datacube.py
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ def from_fiona(
if len(paths) != 1:
# TODO #114 EP-3981: support multiple paths
raise FeatureUnsupportedException(message="Loading a vector cube from multiple files is not supported")
columns_for_cube = options.get("columns_for_cube", cls.COLUMN_SELECTION_NUMERICAL)
columns_for_cube = (options or {}).get("columns_for_cube", cls.COLUMN_SELECTION_NUMERICAL)
# TODO #114 EP-3981: lazy loading like/with DelayedVector
# note for GeoJSON: will consider Feature.id as well as Feature.properties.id
if "parquet" == driver:
Expand Down
2 changes: 1 addition & 1 deletion tests/test_vectorcube.py
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ def test_from_geometry(self, geometry, expected):
],
)
def test_from_fiona(self, path, driver):
vc = DriverVectorCube.from_fiona([path], driver=driver, columns_for_cube=[])
vc = DriverVectorCube.from_fiona([path], driver=driver, options={"columns_for_cube": []})
assert vc.to_geojson() == DictSubSet(
{
"type": "FeatureCollection",
Expand Down

0 comments on commit 4bdd41f

Please sign in to comment.