WP5 indiv process testing: code style improvements

[soxofaan]

This is rebased version of PR #21 after it got in messy conflict with main branch

[m-mohr]

I can confirm that #21 and #32 do the same, so #21 can be closed.

Nevertheless, the missing warnings are still a thing. See #21 (comment)

Otherwise lgtm

[soxofaan]

about the missing warnings issue, I did some digging:

warnings.warn

• only shown in CLI output, not present in HTML report
• shows up for both passing and failing tests
• has a feature to suppress repeated warnings, which might be confusing when trying to connect certain warnings with tests that actually triggered it

log.warning

• shows up in both CLI output and HTML report
• by default, only shown in CLI output for failing tests, but can be enabled for passing tests too (e.g. --log-cli-level=WARN)
• in HTML report shown for both failing and passing tests

I think in general log.warning should be prefered over warnings.warn.

[soxofaan]

I'll go ahead and merge this, because there is too much risk on conflicts with other issues/PRs I want to work on

[m-mohr]

I can't confirm this. From what you've stated above, I'd have assumed that adding --log-cli-level=WARN would add the missing warnings back to the log, but it doesn't. They are still missing and we still don't understand why this is the case, so this PR doesn't accomplish what it suggests: Code style improvements (only).

[m-mohr]

Okay, I see what happens here:
Instead of showing up in the warnings summary:

They now show up in the live log setup:

That is confusing. They are also not identified as warnings by pytest. Is there a way to fix this, @soxofaan ?

[m-mohr]

Moved the issue to #33 to unblock this PR.

[m-mohr]

Approving with the caveat of the open issue in #33

[soxofaan]

thanks

merged in 0e7a7d7