Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake8 in develop gets sloppy #2374

Closed
ReimarBauer opened this issue May 19, 2024 · 3 comments · Fixed by #2394
Closed

flake8 in develop gets sloppy #2374

ReimarBauer opened this issue May 19, 2024 · 3 comments · Fixed by #2394
Labels
Milestone

Comments

@ReimarBauer
Copy link
Member

I recognized that his was not show as failure by our flake8 checket.

#2373 (comment)

@matrss
Copy link
Collaborator

matrss commented May 19, 2024

Yes, because flake8 is only run for mslib/ and tests/. I don't know why this decision was made, I've already noted that this is not great in #2145 (comment). We should enable it for the entire repository, including e.g. tutorials/, docs/, setup.py, etc.

@matrss
Copy link
Collaborator

matrss commented May 19, 2024

And we should revisit the list of globally ignored lint rules and check if we really want to skip them or if they would make sense to enable.

@ReimarBauer
Copy link
Member Author

ReimarBauer commented May 20, 2024

I think we should change flake8 check for the whole dir. I guess after adding tutorials we forget to adopt the rules and we thought only on dir levels. docs/conf.py was initially autogenerated

We have to check with Joern for the all lint rules option.

@matrss matrss added this to the 9.0.1 milestone May 29, 2024
@matrss matrss closed this as completed May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants