Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run flake8 for all .py files tracked in git #2394

Merged
merged 2 commits into from
May 29, 2024

Conversation

matrss
Copy link
Collaborator

@matrss matrss commented May 24, 2024

Purpose of PR?:

Fixes #2374.

Does this PR introduce a breaking change?

If the changes in this PR are manually verified, list down the scenarios covered::

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Does this PR results in some Documentation changes?
If yes, include the list of Documentation changes

Checklist:

  • Bug fix. Fixes #
  • New feature (Non-API breaking changes that adds functionality)
  • PR Title follows the convention of <type>: <subject>
  • Commit has unit tests

@matrss matrss changed the base branch from develop to stable May 24, 2024 14:39
@matrss matrss marked this pull request as ready for review May 24, 2024 15:34
@matrss matrss requested a review from ReimarBauer May 24, 2024 15:34
docs/conf.py Outdated Show resolved Hide resolved
Copy link
Member

@ReimarBauer ReimarBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs few changes for making readthedocs happy.

@matrss matrss requested a review from ReimarBauer May 27, 2024 08:52
Copy link
Member

@ReimarBauer ReimarBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matrss matrss merged commit 8e673ad into Open-MSS:stable May 29, 2024
10 checks passed
@matrss matrss deleted the flake8-everywhere branch May 29, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flake8 in develop gets sloppy
2 participants