Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge stable to develop #2344

Merged
merged 1 commit into from
May 13, 2024
Merged

Merge stable to develop #2344

merged 1 commit into from
May 13, 2024

Conversation

ReimarBauer
Copy link
Member

Purpose of PR?:

needs a merge

@ReimarBauer ReimarBauer marked this pull request as draft May 8, 2024 07:47
@ReimarBauer ReimarBauer marked this pull request as ready for review May 8, 2024 08:22
@ReimarBauer ReimarBauer requested a review from matrss May 8, 2024 08:48
matrss
matrss reviewed May 8, 2024
View reviewed changes
.github/workflows/lint.yml Outdated Show resolved Hide resolved
@ReimarBauer
Copy link
Member Author

there will be another merge after the release of 8.3.5

matrss
matrss approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@matrss matrss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just for the record, I reviewed this contrary to what I said in #2332, but only because it contains a singular change from me and nothing else.

@ReimarBauer ReimarBauer merged commit 037ba61 into develop May 13, 2024
10 checks passed
@ReimarBauer ReimarBauer deleted the merge_stable_to_develop branch May 13, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matrss matrss matrss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ReimarBauer @matrss