Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12/10/2022]: Backend API [feat] - Project structure #14

Merged

Conversation

RealRichi3
Copy link
Member

@RealRichi3 RealRichi3 commented Oct 13, 2022

Summary

Setup NodeJS MVC app structure for the BACKEND API for MOOCs platform issue #5

.....
backend_API/
  -- node_modules/
  -- src/
       -- controllers/
       -- routes/
           -- routes_handler.js
       -- models/
       -- db/
       -- test/
       -- utils/
             -- async_wrapper.js
             -- config.js
       -- .env
       -- app.js
       -- server.js
package-lock.json
package.json

Fixes issue #13

List of changes proposed in this PR (pull-request)

  • Added project structure for backend API
  • Added database connection
  • Setup MVC app structure

What should a reviewer concentrate their feedback on?

  • Everything looks ok?

@RealRichi3
Copy link
Member Author

@BatoolMM this is the pull request to add the Backend API project structure as explained in issue #5.
Please review and merge to dev branch so others can pull and start working on the tasks

@BatoolMM
Copy link
Member

Thank you @RealRichi3 for your hard work!

Just to double-check, I just merged PR #14 for dev branch. Would you like to have your work at the same dev branch or I can create another one if you are working in different groups?

@RealRichi3
Copy link
Member Author

Thanks @BatoolMM, i would be better to work on a different branch, but we were hoping to discuss more on that tomorrow

@BatoolMM
Copy link
Member

I created a new branch called dev_team2 just in case you want to use it.

@RealRichi3
Copy link
Member Author

Perfect, but will the zoom session for tomorrow still hold?

@BatoolMM
Copy link
Member

Hi @RealRichi3, I am very sorry that this will be postponed till Tuesday at the same time. This was outside our control, but we are happy to support you and answer questions you have. I think the best way to resolve this PR is to create another one directed toward a dev_team2 branch. Let us know if you want to proceed using a different approach, @alswajiab and I will help you with it 🌻

@BatoolMM BatoolMM closed this Oct 14, 2022
@BatoolMM BatoolMM reopened this Oct 14, 2022
@BatoolMM
Copy link
Member

Apologies, it was closed by mistake, it is re-opened now!

@RealRichi3
Copy link
Member Author

Hi @RealRichi3, I am very sorry that this will be postponed till Tuesday at the same time. This was outside our control, but we are happy to support you and answer questions you have. I think the best way to resolve this PR is to create another one directed toward a dev_team2 branch. Let us know if you want to proceed using a different approach, @alswajiab and I will help you with it 🌻

Alright, i guess we'll go with it. The issue i had was that, since the project plan has been set in issue #5, every pull request to the branch has to be reviewed so it'll be inline with the project plan, i'd like to suggest that i should review all pull request made to dev_team2, if it's ready for merge then i can tag you saying 'reviewed and ready to merge'.

@RealRichi3
Copy link
Member Author

Another idea.

Since the backend and frontend are part of the main plan in issue #2, we can just use one branch, then two separate folders in it, the front end work will be done in the frontend folder, then the code for backend will de done in backend. I think this will be good so we won't need to open so many branches.
This way it'll be one branch per proposal

For this proposal @sandyguide can review all PR related to the frontend issue #10
And I can review all PR related to backend api issue #5

Once reviewed we can just comment reviewed and ready to merge then you can merge. This way it'll be inline with the main proposal in #2 and collaboration for #10 and #5 would be more effective

@BatoolMM
Copy link
Member

I love the way you have been managing and organising the protject @RealRichi3. I created a new tag ready to merge. Feel free to use it and either me or @alswajiab will merge your PR. Let us know if you need any other thing!

@sandygudie
Copy link
Member

sandygudie commented Oct 14, 2022

@RealRichi3 just to be sure, are we using the dev branch or dev_team2 branch?

@RealRichi3
Copy link
Member Author

@sandygudie let's go for the dev_team

@RealRichi3
Copy link
Member Author

I love the way you have been managing and organising the protject @RealRichi3. I created a new tag ready to merge. Feel free to use it and either me or @alswajiab will merge your PR. Let us know if you need any other thing!

Thanks @BatoolMM, i Will make the PR to dev_team so we can start contributing

@sandygudie
Copy link
Member

sandygudie commented Oct 14, 2022

Alright then, i will set up a frontend structure for dev_team2 branch

@RealRichi3
Copy link
Member Author

Sorry it's dev_team2

@RealRichi3
Copy link
Member Author

@BatoolMM is there a way to direct this particular PR to dev_team2 branch instead of having to make a new PR to dev_team2

@RealRichi3
Copy link
Member Author

@sandygudie it's dev_team2 not dev_team

@RealRichi3 RealRichi3 changed the base branch from dev to dev_team2 October 14, 2022 12:12
@RealRichi3
Copy link
Member Author

RealRichi3 commented Oct 14, 2022

@BatoolMM it's ready to merge to dev_team2 now

@RealRichi3
Copy link
Member Author

I love the way you have been managing and organising the protject @RealRichi3. I created a new tag ready to merge. Feel free to use it and either me or @alswajiab will merge your PR. Let us know if you need any other thing!

@BatoolMM how do we add the ready to merge tag?

@BatoolMM
Copy link
Member

Brilliant, it's merged now!

@BatoolMM BatoolMM merged commit ce34fe4 into Open-Science-Community-Saudi-Arabia:dev_team2 Oct 14, 2022
@RealRichi3 RealRichi3 changed the title [12/10/2022]: Backend API (feat) - Project structure [12/10/2022]: Backend API [feat] - Project structure Oct 15, 2022
@BatoolMM
Copy link
Member

@RealRichi3 , let me know if you still can't access ready to merge tag!

@sandygudie sandygudie mentioned this pull request Oct 19, 2022
16 tasks
RealRichi3 pushed a commit to RealRichi3/MOOCs that referenced this pull request Feb 21, 2023
…chi3/backend/dev

[12/10/2022]: Backend API (feat) - Project structure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants