Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show password state management #76

Open
wants to merge 1 commit into
base: dev_team2
Choose a base branch
from

Conversation

JesperKawuma
Copy link

@JesperKawuma JesperKawuma commented Oct 22, 2022

Summary

  • Added a show password icon with react-icons to the Login and Signup pages.
  • Added event handlers and state management to inputs and the show password logic.

Fixes #75

What should a reviewer concentrate their feedback on?

Copy link
Author

@JesperKawuma JesperKawuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @BatoolMM @sandygudie, can you please guide me on how to improve this?

@sandygudie
Copy link
Member

@JesperKawuma which page are you working on?

@JesperKawuma
Copy link
Author

I have implemented this in Login and Signup pages @sandygudie

@okerekechinweotito
Copy link
Contributor

@JesperKawuma I have gone through your code and I understand what you did. Attach a picture of the Login and Signup showing the password icon for visual confirmation. Good Job

@sandygudie
Copy link
Member

@JesperKawuma Please can you update your PR description to be more descriptive

  • Include the page you are working on
  • And the problem you are solving
    thanks

@JesperKawuma
Copy link
Author

Hello @sandygudie and @okerekechinweotito, am sorry for the late reply. I had got some issues with my machine.
I have tried to be a bit descriptive and added a screen cast of what I did. Thanks, I am really sorry for the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants