Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course Overview Page #87

Open
wants to merge 4 commits into
base: dev_team2
Choose a base branch
from

Conversation

Eshy10
Copy link

@Eshy10 Eshy10 commented Oct 24, 2022

Summary

Fixes #28
Worked on the Course overview Page as seen on the Figma Design

List of changes proposed in this PR (pull-request)

  • Course Overview Page.

Screenshot 2022-10-24 at 18 39 26

Screenshot 2022-10-24 at 18 32 34

What should a reviewer concentrate their feedback on?

  • Course Overview Page

Screenshot 2022-10-24 at 18 30 50

Also, I added PropTypes Package to fix husky errors.

@Eshy10 Eshy10 changed the title Dev team2 Course Overview Page Oct 24, 2022
@Eshy10
Copy link
Author

Eshy10 commented Oct 24, 2022

Hi @sandygudie the add label and reviewer weren't showing at my end. So I just want to let you know I made a PR. Looking forward to your feedback.

@okerekechinweotito
Copy link
Contributor

@Eshy10
Your implementation looks good
a few quick things you might want to do ...

(1) You forgot to add the link to the issue this PR fixes.
(2) Your branch is 21 commits behind the dev_team2 branch on the main repo. Try to rebase this PR

Screenshot (63)

@Eshy10
Copy link
Author

Eshy10 commented Oct 26, 2022

@

@Eshy10 Your implementation looks good a few quick things you might want to do ...

(1) You forgot to add the link to the issue this PR fixes. (2) Your branch is 21 commits behind the dev_team2 branch on the main repo. Try to rebase this PR

Screenshot (63)

@okerekechinweotito I can't rebase the PR because the option is not showing here. If the merge Pull Request thingy was showing I could do that.

for example, this is a different PR:
Screenshot 2022-10-26 at 14 00 52

But for this one, it is not showing. But I have added the issue link.

@okerekechinweotito
Copy link
Contributor

@Eshy10 You can rebase the branch for this PR on the terminal on your local machine. Here is a free resource to get you started - https://www.freecodecamp.org/news/the-ultimate-guide-to-git-merge-and-git-rebase/

@Eshy10
Copy link
Author

Eshy10 commented Oct 26, 2022

@okerekechinweotito thanks done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants