Skip to content

Conversation

@Dimfacion
Copy link
Member

Proposed changes

  • Batching came back from the dead to haunt us

Testing Instructions

  1. Step-by-step how to test
  2. Environment or config notes

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@Dimfacion Dimfacion force-pushed the issue/2895_2 branch 3 times, most recently from 7cf31ee to 3dbb8b2 Compare September 16, 2025 16:14
@codecov
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

❌ Patch coverage is 27.72586% with 232 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.36%. Comparing base (23b393d) to head (3dbb8b2).
⚠️ Report is 2 commits behind head on release/current.

Files with missing lines Patch % Lines
...st/inject/service/BatchingInjectStatusService.java 0.75% 131 Missing ⚠️
...o/openbas/rest/helper/queue/BatchQueueService.java 46.37% 70 Missing and 4 partials ⚠️
...as/rest/inject/service/InjectExecutionService.java 0.00% 11 Missing ⚠️
...rc/main/java/io/openbas/rest/inject/InjectApi.java 30.76% 9 Missing ⚠️
...nbas/rest/inject/form/InjectExecutionCallback.java 0.00% 3 Missing ⚠️
...er/queue/executor/BatchExecutionTraceExecutor.java 0.00% 2 Missing ⚠️
.../openbas/config/ThreadPoolTaskSchedulerConfig.java 66.66% 1 Missing ⚠️
...a/io/openbas/service/InjectExpectationService.java 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             release/current    #3990      +/-   ##
=====================================================
- Coverage              46.55%   46.36%   -0.19%     
- Complexity              3120     3153      +33     
=====================================================
  Files                    828      835       +7     
  Lines                  24709    25623     +914     
  Branches                1792     1908     +116     
=====================================================
+ Hits                   11503    11880     +377     
- Misses                 12526    13072     +546     
+ Partials                 680      671       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Dimfacion Dimfacion changed the title [backend] Rebasing [backend] Batching injects Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants