Skip to content

Conversation

@gabriel-peze
Copy link
Contributor

@gabriel-peze gabriel-peze commented Oct 21, 2025

Proposed changes

  • Use scenario dependencies instead of fromStarterPack value for more reusable code
  • Add the dependencies value into the scenarios zip files, to get the starterpack information hold by the scenario instead of all the global import process

Testing Instructions

  1. All starterpack scenarios should implement as usual, with dummy injectors or real ones if implemented

Related issues

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 49.52%. Comparing base (09a0057) to head (d2aa37c).
⚠️ Report is 38 commits behind head on release/current.

Files with missing lines Patch % Lines
...main/java/io/openaev/importer/V1_DataImporter.java 92.85% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             release/current    #4295      +/-   ##
=====================================================
+ Coverage              49.50%   49.52%   +0.02%     
- Complexity              3553     3558       +5     
=====================================================
  Files                    884      885       +1     
  Lines                  26326    26340      +14     
  Branches                1957     1957              
=====================================================
+ Hits                   13032    13046      +14     
  Misses                 12509    12509              
  Partials                 785      785              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gabriel-peze gabriel-peze marked this pull request as ready for review October 22, 2025 09:56
@gabriel-peze gabriel-peze self-assigned this Oct 22, 2025
@gabriel-peze gabriel-peze added filigran team use to identify PR from the Filigran team do not merge Do not merge this PR until this tag will be removed labels Oct 22, 2025
@gabriel-peze gabriel-peze linked an issue Oct 22, 2025 that may be closed by this pull request
@gabriel-peze gabriel-peze removed the do not merge Do not merge this PR until this tag will be removed label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve process by avoiding using fromStarterPack boolean

2 participants