-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rust][reqwest] support binary type for download #20031
base: master
Are you sure you want to change the base?
[rust][reqwest] support binary type for download #20031
Conversation
I created a PR with the same code as #18682 to see which tests are failing in the CI. |
The CI needs approval to run, but I can run the tests locally. |
84d510e
to
69fb82c
Compare
Let's update the branch and mark the PR as ready for review? I've described my opinion in the issue: #18117 (comment) |
@DDtKey thanks for the feedback. Did you test the change locally? e.g.
and the build the CLI JAR by running |
1404614
to
860418f
Compare
@wing328 I ran these commands:
And here is the result clean-run.txt. It looks like everything succeeded. So I synced my fork with the upstream repo and rebased my branch on master. So the PR should now contain the latest changes from master. |
860418f
to
3755f3c
Compare
@ThomasVille thanks for the info. Can you please add a fake endpoint in the petstore test spec to test binary return type? test spec: modules/openapi-generator/src/test/resources/3_0/rust/petstore.yaml an example of fake endpoint in other test spec: https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/test/resources/3_0/petstore-with-fake-endpoints-models-for-testing.yaml#L1227-L1267 then regenerate the samples to ensure the changes are good |
fix #18117
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)