Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust][reqwest] support binary type for download #20031

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ThomasVille
Copy link

fix #18117

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@ThomasVille
Copy link
Author

I created a PR with the same code as #18682 to see which tests are failing in the CI.

@ThomasVille
Copy link
Author

The CI needs approval to run, but I can run the tests locally.

@DDtKey
Copy link
Contributor

DDtKey commented Nov 20, 2024

Let's update the branch and mark the PR as ready for review?

I've described my opinion in the issue: #18117 (comment)

@wing328
Copy link
Member

wing328 commented Nov 21, 2024

@DDtKey thanks for the feedback.

Did you test the change locally? e.g.

git checkout -b ThomasVille-rust_binary_type_support master
git pull https://github.com/ThomasVille/openapi-generator.git rust_binary_type_support

and the build the CLI JAR by running mvn clean package (or using maven wrapper included in this repo)

@ThomasVille
Copy link
Author

@wing328 I ran these commands:

git clone [email protected]:OpenAPITools/openapi-generator.git
cd openapi-generator/
git checkout -b ThomasVille-rust_binary_type_support master
git pull https://github.com/ThomasVille/openapi-generator.git rust_binary_type_support
./mvnw clean package

And here is the result clean-run.txt.

It looks like everything succeeded.

So I synced my fork with the upstream repo and rebased my branch on master. So the PR should now contain the latest changes from master.

@ThomasVille ThomasVille marked this pull request as ready for review November 25, 2024 16:01
@ThomasVille ThomasVille changed the title [rust][reqwest] support binary type for upload and download [rust][reqwest] support binary type for download Nov 26, 2024
@wing328
Copy link
Member

wing328 commented Nov 27, 2024

@ThomasVille thanks for the info.

Can you please add a fake endpoint in the petstore test spec to test binary return type?

test spec: modules/openapi-generator/src/test/resources/3_0/rust/petstore.yaml

an example of fake endpoint in other test spec: https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/test/resources/3_0/petstore-with-fake-endpoints-models-for-testing.yaml#L1227-L1267

then regenerate the samples to ensure the changes are good

@wing328 wing328 added this to the 7.11.0 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][Rust][client][reqwest] Wrong representation of binary body (octet-stream) in request/response
3 participants