Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix build issues #905

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix: Fix build issues #905

merged 1 commit into from
Oct 30, 2024

Conversation

KIRA009
Copy link
Contributor

@KIRA009 KIRA009 commented Oct 29, 2024

What kind of change does this PR introduce?
Addresses #901

Summary

  • This largely addresses the app failing to run as found in [Bug]: App broken #901.
  • It also fixes the windows build

Checklist

  • My code follows the style guidelines of OpenAdapt
  • I have performed a self-review of my code
  • If applicable, I have added tests to prove my fix is functional/effective
  • I have linted my code locally prior to submission
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. README.md, requirements.txt)
  • New and existing unit tests pass locally with my changes

How can your code be run and tested?
Build the app and run it

Other information

@abrichr
Copy link
Member

abrichr commented Oct 29, 2024 •
edited
Loading

@KIRA009 thank you! 🙏

Is this ready to merge?

@KIRA009
Copy link
Contributor Author

KIRA009 commented Oct 30, 2024

@KIRA009 thank you! 🙏

Is this ready to merge?

I am fixing the build as well in this PR

@KIRA009 KIRA009 force-pushed the main branch 2 times, most recently from b0b8bf7 to a550a34 Compare October 30, 2024 09:02
@KIRA009 KIRA009 marked this pull request as ready for review October 30, 2024 09:26
@KIRA009
Copy link
Contributor Author

KIRA009 commented Oct 30, 2024

@abrichr This is now ready

abrichr
abrichr approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@abrichr abrichr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@abrichr abrichr merged commit e7ad4e5 into OpenAdaptAI:main Oct 30, 2024
1 check passed
@abrichr abrichr mentioned this pull request Oct 31, 2024
Closed
@abrichr abrichr mentioned this pull request Nov 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abrichr abrichr abrichr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KIRA009 @abrichr