Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use subqueryload for all joins in get_screenshots #920

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

KIRA009
Copy link
Contributor

@KIRA009 KIRA009 commented Nov 15, 2024

What kind of change does this PR introduce?
This PR fixes a bug with loading strategies

Summary
FIxes a bug where different loading strategies are used to access the same relation, resulting in a mapping error. This is fixed by using the same subqueryload across all loads, as it is recommended for loading data when the related data is in large numbers

Checklist

  • My code follows the style guidelines of OpenAdapt
  • I have performed a self-review of my code
  • If applicable, I have added tests to prove my fix is functional/effective
  • I have linted my code locally prior to submission
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. README.md, requirements.txt)
  • New and existing unit tests pass locally with my changes

How can your code be run and tested?

Run the project, go to any recording detail page, and ensure that the page is rendered with the correct screenshots and action event data

Other information

@KIRA009 KIRA009 changed the title fix: Use subqueryload for all joins Use subqueryload for all joins in get_screenshots Nov 15, 2024
Copy link
Member

@abrichr abrichr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abrichr abrichr merged commit a73439a into OpenAdaptAI:main Nov 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants